This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: ipns publish resolve option overwritten #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
fix/ipns-publish-resolve-option-overwritten
branch
from
5ec00d7
to
81c8247
Compare
vasco-santos
force-pushed
the
fix/ipns-publish-resolve-option-overwritten
branch
from
81c8247
to
c582314
Compare
alanshaw
approved these changes
Sep 11, 2018
|
Merging as errors are problems with jenkins and not related to this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yargs-promiseadds resolve/reject properties toargv.This way,
resolveoption was being overwritten to a function and, as it was notfalse, it was defined always as true for thepublishoperation.Publish should use the
ralias instead, as resolve will always be overwritten to a function.