Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

http api not validating if content-type header is present. #1291

Closed
wraithgar opened this issue Apr 2, 2018 · 1 comment
Closed

http api not validating if content-type header is present. #1291

wraithgar opened this issue Apr 2, 2018 · 1 comment

Comments

@wraithgar
Copy link
Contributor

The 'add files' endpoint of the http api passes the content-type header down into ipfs-multipart, which passes it down into the content library which was not checking for that header's presence before trying to parse it, resulting in a traceback and 500 error.

This has been patched in content and a pr for ipfs-multipart has been opened here: ipfs-inactive/js-ipfs-multipart#1

When that PR is either merged or the issue addressed manually we can then update the ipfs-multipart dependency in this repo and close this issue.

@daviddias daviddias added kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked and removed P2 Medium: Good to have, but can wait until someone steps up kind/bug A bug in existing code (including security flaws) labels Jun 4, 2018
@alanshaw
Copy link
Member

alanshaw commented Nov 1, 2018

Closing as ipfs-inactive/js-ipfs-multipart#1 has been merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants