-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add wrap-with-directory support (HTTP API and Core) #1178
Comments
Hey @nunofmn o/ Yeah, add it to interface-ipfs-core. You can submit both PRs at the same time :) |
@nunofmn ping :) Still interested in submitting that PR? |
I am quite interested in this feature, as it allows to use the human readable filenames and also to have the filename extension which is useful for [browsers?] recognizing the mime type. What is the current development status of this feature? Is anybody working on this ? |
I'm attempting to work on this on the js side of things. Just getting started ramping up here so your patience is very much appreciated! |
I've been looking at a workaround which uses the recursive option and passes in a directory selected from a HTML5 input directory. I have been having trouble with this and I'm not sure exactly why, it might be something to do with asynchronous loading of the files. I'm interested if anyone else has tried this. |
Took a stab at this, see the three PRs linked to above. |
@wraithgar looking good! I'll handle merging and releasing those soon (probably earlier tomorrow) :) Thank you! |
Thanks guys I'm looking forward to seeing this. |
Closing this since #1329 was merged. |
Related to ipfs/ipfs-companion#349
Right now, the
wrap-with-directory
option only works in CLI and support in HTTP API and Core is missingI already have a working solution that uses the
wrap
option in js-ipfs-unixfs-engine Importer API.Question: it is necessary add support to this option in interface-ipfs-core beforehand? (or maybe at least add a tracking issue)
I'm looking forward to open a PR 👍
The text was updated successfully, but these errors were encountered: