Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Keychain options #1139

Closed
2 tasks done
richardschneider opened this issue Dec 9, 2017 · 2 comments
Closed
2 tasks done

Keychain options #1139

richardschneider opened this issue Dec 9, 2017 · 2 comments

Comments

@richardschneider
Copy link
Contributor

richardschneider commented Dec 9, 2017

The default keychain options should be in config under Keychain.

const defaultOptions = {
  // See https://cryptosense.com/parametesr-choice-for-pbkdf2/
  dek: {
    keyLength: 512 / 8,
    iterationCount: 10000,
    salt: 'you should override this value with a crypto secure random number',
    hash: 'sha512'
  }
}
  • ipfs init should generate a random salt and add to config
  • during startup, these value should be used to construct the keychain
@daviddias
Copy link
Member

@richardschneider did you really want to close this one?

@richardschneider
Copy link
Contributor Author

@diasdavid the code has been implemented in PR #1133, so why not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants