-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Submodule Structure #11
Comments
from irc:
Adding to that: if there is enough interest from people, happy to do a short plan + sprint to clean this up. maybe interested people could come discuss on irc sometime this week? |
Hey Guys, is this the official repo? If so i'd be happy to help on reformatting to a more npm friendly structure. No git submodule voodoo magic. There's two ways: Seperate Repo way:
Simple file.js Way:
If you guys want to look at good example of a npm formats i know: Good Resources: |
In terms of a README alternative, using github's wiki is a good option. |
Going to close this issue as it respects to the (waay waay) old js-ipfs :) @Latrasis if you have free cycles to help ship js-ipfs, join the 🚢 ! :D |
I understand you want to modularize the project, but breaking up into a huge tree of git submodules is a little insane. Node already uses a module system by default, so we can put the same module structure you designed into directories. Each one as its own repo just makes the project a pain to maintain and to contribute to. If we move the modules into directories we will barely need to change the code, since the modules can still be loaded via
require
.There are projects with similar scope/size, and they all work great with the standard Node way of organizing modules. (E.g. Dat, which I know you've contributed to).
Overall, the current structure adds painful management overhead, will likely scare off contributors, and doesn't provide anything over the built-in Node module system. Should I go ahead and refactor?
The text was updated successfully, but these errors were encountered: