This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Fix the welcome message and throw error when trying to cat a non-exis… #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atvanguard can you please add some tests verifying this works. |
|
@dryajov Added. Let me know if something needs to be improved. |
|
@atvanguard Looking good. Mind checking my comment? Otherwise, LGTM |
daviddias
approved these changes
Oct 13, 2017
daviddias
suggested changes
Oct 13, 2017
There was a problem hiding this comment.
Realized now that tests are failing. @atvanguard could you check that?
|
@diasdavid Incorporated the changes and increased the timeout for a test that was failing. |
daviddias
approved these changes
Oct 16, 2017
daviddias
approved these changes
Oct 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tent file [Fixes #1031]