Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Commit

Permalink
chore: add @types/yargs for better inference (#3357)
Browse files Browse the repository at this point in the history
This was prompted by #3353. I am guessing that something end up pulling old version of `@types/yargs` that was unaware of `onFinishCommand`. This pull explicitly adds latest `@types/yargs` into `ipfs-cli` dev dependencies which:

1. Seems to be aware of `onFinishCommand`.
2. Makes ipfs-cli aware of yargs interface, which without this just appears as `any`.
  • Loading branch information
Gozala authored Oct 28, 2020
1 parent 16ecc74 commit b07f944
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 2 additions & 1 deletion packages/ipfs-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@
"string-argv": "^0.3.1",
"temp-write": "^4.0.0",
"typescript": "^4.0.3",
"wrtc": "^0.4.6"
"wrtc": "^0.4.6",
"@types/yargs": "^15.0.9"
},
"optionalDependencies": {
"prom-client": "^12.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/ipfs-cli/src/parser.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict'

// @ts-ignore
const yargs = require('yargs/yargs')(process.argv.slice(2))
const utils = require('./utils')

Expand Down

0 comments on commit b07f944

Please sign in to comment.