fix: swarm.peers latency value when unknown (#2336)

go-ipfs returns "n/a" when latency is unknown. This change restores compatibility. License: MIT Signed-off-by: Alan Shaw <[email protected]>
ipfs · Aug 6, 2019 · 6248ec1 · 6248ec1
1 parent 128efec
commit 6248ec1
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 12 deletions.
diff --git a/package.json b/package.json
@@ -190,7 +190,7 @@
     "execa": "^2.0.3",
     "form-data": "^2.5.0",
     "hat": "0.0.3",
-    "interface-ipfs-core": "~0.107.3",
+    "interface-ipfs-core": "^0.109.1",
     "ipfsd-ctl": "^0.43.0",
     "libp2p-websocket-star": "~0.10.2",
     "ncp": "^2.0.0",

diff --git a/src/core/components/swarm.js b/src/core/components/swarm.js
@@ -34,7 +34,7 @@ module.exports = function swarm (self) {
           peer: peer.id
         }
         if (verbose) {
-          tupple.latency = 'unknown'
+          tupple.latency = 'n/a'
         }
 
         peers.push(tupple)

diff --git a/test/core/interface.spec.js b/test/core/interface.spec.js
@@ -17,10 +17,20 @@ describe('interface-ipfs-core tests', function () {
   tests.bootstrap(defaultCommonFactory)
 
   tests.config(defaultCommonFactory, {
-    skip: [{
-      name: 'should set a number',
-      reason: 'Failing - needs to be fixed'
-    }]
+    skip: [
+      {
+        name: 'should set a number',
+        reason: 'Failing - needs to be fixed'
+      },
+      {
+        name: 'should output changes but not save them for dry run',
+        reason: 'TODO unskip when https://github.com/ipfs/js-ipfs/pull/2165 is merged'
+      },
+      {
+        name: 'should set a config profile',
+        reason: 'TODO unskip when https://github.com/ipfs/js-ipfs/pull/2165 is merged'
+      }
+    ]
   })
 
   tests.dag(defaultCommonFactory)
@@ -119,7 +129,14 @@ describe('interface-ipfs-core tests', function () {
     }
   }))
 
-  tests.object(defaultCommonFactory)
+  tests.object(defaultCommonFactory, {
+    skip: [
+      {
+        name: 'should respect timeout option',
+        reason: 'js-ipfs doesn\'t support timeout yet'
+      }
+    ]
+  })
 
   tests.pin(defaultCommonFactory)
 

diff --git a/test/http-api/interface.js b/test/http-api/interface.js
@@ -17,10 +17,20 @@ describe('interface-ipfs-core over ipfs-http-client tests', () => {
   tests.bootstrap(defaultCommonFactory)
 
   tests.config(defaultCommonFactory, {
-    skip: [{
-      name: 'should set a number',
-      reason: 'Failing - needs to be fixed'
-    }]
+    skip: [
+      {
+        name: 'should set a number',
+        reason: 'Failing - needs to be fixed'
+      },
+      {
+        name: 'should output changes but not save them for dry run',
+        reason: 'TODO unskip when https://github.com/ipfs/js-ipfs/pull/2165 is merged'
+      },
+      {
+        name: 'should set a config profile',
+        reason: 'TODO unskip when https://github.com/ipfs/js-ipfs/pull/2165 is merged'
+      }
+    ]
   })
 
   tests.dag(defaultCommonFactory, {
@@ -122,7 +132,14 @@ describe('interface-ipfs-core over ipfs-http-client tests', () => {
     }
   }))
 
-  tests.object(defaultCommonFactory)
+  tests.object(defaultCommonFactory, {
+    skip: [
+      {
+        name: 'should respect timeout option',
+        reason: 'js-ipfs doesn\'t support timeout yet'
+      }
+    ]
+  })
 
   tests.pin(defaultCommonFactory)