fix: coerce key gen size to number (#1582)

Keychain params are now validated properly and has caused these test to fail libp2p/js-libp2p-keychain#26 License: MIT Signed-off-by: Alan Shaw <[email protected]>
ipfs · Sep 18, 2018 · 25d820d · 25d820d
1 parent c52ee03
commit 25d820d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/cli/commands/key/gen.js b/src/cli/commands/key/gen.js
@@ -16,7 +16,8 @@ module.exports = {
     size: {
       alias: 's',
       describe: 'size of the key to generate.',
-      default: '2048'
+      default: 2048,
+      type: 'number'
     }
   },
 

diff --git a/src/http/api/resources/key.js b/src/http/api/resources/key.js
@@ -64,7 +64,7 @@ exports.gen = (request, reply) => {
   const ipfs = request.server.app.ipfs
   const name = request.query.arg
   const type = request.query.type
-  const size = request.query.size
+  const size = parseInt(request.query.size)
   ipfs._keychain.createKey(name, type, size, (err, key) => {
     if (err) {
       return applyError(reply, err)