Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate relevant types from ipfs repo to this repo #94

Closed
Gozala opened this issue Nov 12, 2020 · 1 comment
Closed

Migrate relevant types from ipfs repo to this repo #94

Gozala opened this issue Nov 12, 2020 · 1 comment
Labels
status/ready Ready to be worked

Comments

@Gozala
Copy link
Contributor

Gozala commented Nov 12, 2020

As per discussion here https://github.com/ipfs/js-ipfs/pull/3365/files/fa7c2c13c43bab922052104fe8aff863d9725e9b?file-filters%5B%5D=.js&file-filters%5B%5D=.json&file-filters%5B%5D=.ts#r520397622 there are bunch of type definitions that belong here instead of in js-ipfs repo.

We should migrate them here.
@Gozala Gozala added the need/triage Needs initial labeling and prioritization label Nov 12, 2020
@Gozala Gozala mentioned this issue Nov 12, 2020
Merged
@achingbrain achingbrain added status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Dec 16, 2020
@achingbrain
Copy link
Member

This module has types now so any consumers of this module should use the types exported by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gozala @achingbrain