Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Resolve with a POJO response #6

Open
satazor opened this issue Aug 2, 2018 · 1 comment
Open

Resolve with a POJO response #6

satazor opened this issue Aug 2, 2018 · 1 comment
Labels
good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@satazor
Copy link
Contributor

satazor commented Aug 2, 2018

Instead of resolving with the WHATWG response, we could resolve with a POJO object. This would allow both js-ipfs and the service-worker-gateway to use the whole module. At the moment, there's some duplication going around.

@vasco-santos vasco-santos added kind/enhancement A net-new feature or improvement to an existing feature good first issue Good issue for new contributors labels Aug 2, 2018
@daviddias daviddias added the status/ready Ready to be worked label Aug 25, 2018
@lidel
Copy link
Member

lidel commented Sep 28, 2018

+1
If we had POJOs, I could re-use entire thing in native handler of IPFS Companion as well.

Right now we need to duplicate code related to:

Places where code is duplicated:

  1. HTTP Gateway exposed by service-worker-gateway
  2. HTTP Gateway exposed by js-ipfs
  3. Native protocol handler in ipfs-companion

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

4 participants