This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: dht.findProvs.js handle valid hash but no providers #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niinpatel
force-pushed
the
fix/findProvs-valid-hash-but-no-providers
branch
from
646ae57
to
3fc1641
Compare
niinpatel
changed the title
niinpatel
force-pushed
the
fix/findProvs-valid-hash-but-no-providers
branch
2 times, most recently
from
486e1d9
to
52cd436
Compare
niinpatel
force-pushed
the
fix/findProvs-valid-hash-but-no-providers
branch
from
52cd436
to
49b16ec
Compare
alanshaw
previously approved these changes
Mar 14, 2019
alanshaw
suggested changes
Mar 14, 2019
src/dht/findprovs.js
Outdated
| @@ -23,6 +23,12 @@ module.exports = (send) => { | |||
| } | |||
|
|
|||
| const handleResult = (res, callback) => { | |||
| // callback with an empty array if no providers are found | |||
| if (res === null) { | |||
There was a problem hiding this comment.
According to the issue, res is undefined so this change won't resolve the issue. Suggestion below (which will catch both null and undefined):
Suggested change
| if (res === null) { | |
| if (res == null) { |
A small unit test to assert this, that mocks out send would have caught this!
There was a problem hiding this comment.
or instead of double equals, we can do if (!res) { ... }
niinpatel
force-pushed
the
fix/findProvs-valid-hash-but-no-providers
branch
from
49b16ec
to
71f5c21
Compare
License: MIT Signed-off-by: Nitin Patel <[email protected]>
niinpatel
force-pushed
the
fix/findProvs-valid-hash-but-no-providers
branch
from
71f5c21
to
75552f6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #928