Feat/async await #202
Merged
Feat/async await #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make `getMany()` AsyncIterable
* make `putMany()` AsyncIterable * remove check in `_findAndConnect()`
Closed
Still pending PeerId and PeerInfo async/await - they've been done but we can't use them until libp2p update libp2p-secio so use promisify in the interim where necessary, which is only in the tests.
achingbrain
force-pushed
the
feat/async-await
branch
from
31331c2
to
af14f24
Compare
hugomrdias
suggested changes
Sep 20, 2019
achingbrain
force-pushed
the
feat/async-await
branch
from
ea846e5
to
4848b15
Compare
hugomrdias
approved these changes
Sep 20, 2019
dirkmc
commented
Sep 23, 2019
Co-Authored-By: dirkmc <[email protected]>
|
It makes me a bit nervous that the tests were passing when the protocols were switched around. @achingbrain do you think it's worth adding a test to catch that case? |
|
It worked because all nodes in the tests are JS nodes and the message deserialization code handles both message versions by checking to see if the relevant fields exist. I guess we could add a 'strict' mode that only processes one version of bitswap but that sounds beyond the scope of this PR. |
|
Ok fair enough - I can't officially approve as I opened the PR, but LGTM 👍 Let me know if and when you want me to merge + release |
|
Yes please, whenever you can :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #192
This PR depends on a number of async/await PRs that are still WIP (peer-id, peer-info, etc) so it is still some way from being ready.