Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--cfg doesn't work #56

Open
Stebalien opened this issue Jul 3, 2018 · 2 comments
Open

--cfg doesn't work #56

Stebalien opened this issue Jul 3, 2018 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

The related code in IpfsInit is commented out.

@whyrusleeping was that a mistake or did this never work?

@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jul 3, 2018
@dgrisham
Copy link
Member

Hm, from what I can tell the option to override the default IPFS config isn't supported right now (the codebase has changed a lot since then). Is that right @travisperson, @frrist? Do we still want this?

@travisperson
Copy link
Member

Ya, this feature was stripped out when we made iptb more generic. There is currently a Config interface that works on an interface{}, though maybe this should be a string / byte slice and allow the plugin to encode / decode.

type Config interface {
Core
// Config returns the configuration of the node
Config() (interface{}, error)
// WriteConfig writes the configuration of the node
WriteConfig(interface{}) error
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants