New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dependency on Buffer global #453

Open

SgtPooki opened this issue Oct 18, 2024 · 0 comments

Labels

effort/hours exp/novice good first issue help wanted P2 status/ready

Member

SgtPooki commented Oct 18, 2024 •

edited

Loading

ipld-explorer-components/src/lib/normalise-dag-node.ts

Line 127 in 5c97183

    
           if (obj == null || typeof obj !== 'object' || Buffer.isBuffer(obj) || typeof obj === 'string') {

I don't think this would ever return true. see https://nodejs.org/api/buffer.html#static-method-bufferisbufferobj

SgtPooki added help wanted good first issue exp/novice P2 effort/hours status/ready labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment