Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: responsive navbar on small devices #1547

Merged
merged 1 commit into from
Jul 16, 2020
Merged

fix: responsive navbar on small devices #1547

merged 1 commit into from
Jul 16, 2020
+14 −1

Conversation

rafaelramalho19
Copy link
Contributor

Pipeline was failing sometimes https://app.circleci.com/pipelines/github/ipfs-shipyard/ipfs-webui/301/workflows/7d739c8e-9f97-4ad9-a870-fb889442f7d9/jobs/4074 saying that "Explore" link was not clickable.

I think it was because the window used by the CI was too small, hiding the element.

Hopefully this PR fixes it, will rekick the pipeline a couple of times to make sure 🙏

@rafaelramalho19 rafaelramalho19 self-assigned this Jul 16, 2020
@rafaelramalho19 rafaelramalho19 added the kind/bug A bug in existing code (including security flaws) label Jul 16, 2020
@rafaelramalho19
Copy link
Contributor Author

rafaelramalho19 commented Jul 16, 2020 •
edited
Loading

Before this PR:
image

After this PR:
image

@rafaelramalho19 rafaelramalho19 merged commit b24956a into master Jul 16, 2020
@rafaelramalho19 rafaelramalho19 deleted the fix/responsive-navbar branch July 16, 2020 18:13
lidel
lidel reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to suggest just bumping resolution in the initial e2e setup:

https://github.com/ipfs-shipyard/ipfs-webui/blob/6adc355d398df620ce18e0f3496f89d8775f6e5e/test/e2e/setup/test-environment.js#L19

but I like your approach, it is more organic :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

@olizilla olizilla Awaiting requested review from olizilla

Assignees

@rafaelramalho19 rafaelramalho19

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelramalho19 @lidel