fix: PDF viewer refreshes when interacting with web UI #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
lidel
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Thank you @MattWong-ca, this looks like a sensible fix.
I confirmed this not only fixes PDF preview, but also Video (it no longer get interrupted).
|
🎉 This PR is included in version 4.3.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
SgtPooki
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Files, the PDF viewer was re-rendering when interacting with web UI.
In FilesPage.js,
MainViewis defined as a new component inside theFilesPagecomponent, so clicking UI elements around the PDF re-rendersMainView(and sinceMainViewcontains the logic that shows the file preview component, the preview re-renders). Issue seemed to only affect PDFs.Fix: creating and using a new file preview component defined outside of
FilePages. Not sure if this is the cleanest approach, so I'm open to suggestions!Closes #2145
PDF.Viewer.mov