Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change save button contrast as global color edit #1379

Closed
lidel opened this issue Jan 27, 2020 · 5 comments · Fixed by #1467
Closed

Change save button contrast as global color edit #1379

lidel opened this issue Jan 27, 2020 · 5 comments · Fixed by #1467
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work

Comments

@lidel
Copy link
Member

lidel commented Jan 27, 2020

(this may be subjective), but the "Save" button on "Settings" screen in "active" state (when config was changed but not saved yet) feels pretty "inactive":

Screenshot_2020-01-27 Settings - IPFS

Ref. how similar problem was fixed in ProtoSchool/protoschool.github.io#317

@lidel lidel added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up P4 - Very Low topic/design-front-end Front-end implementation of UX/UI work labels Jan 27, 2020
@ericronne
Copy link

It's not your imagination @lidel. At about 1.9:1, the contrast ratio for the teal button label is way below the 4.5:1 standard. (Whereas the text on the gray button clocks in at an impressive 8.8:1)

#378085 is one color that works

x

@lidel
Copy link
Member Author

lidel commented Feb 4, 2020

Thank you @ericronne! Do you think this color is generic enough to be added to ipfs-css and used across our apps in cases like this, or should we punt this until we have time to refresh https://github.com/ipfs/ipfs-gui/blob/master/img/ipfs-ui-kit.png and see how the bigger picture looks like?

@ericronne
Copy link

I think it would be safe to globally swap in #378085 for the #3e9096 on the webui palette. Without actually trying it, it's tricky to know if there's a color combo in some distant corner of the UI will look a little off because of this. Seems like a pretty safe bet, tho.

x

@jessicaschilling jessicaschilling added P3 Low: Not priority right now and removed P4 - Very Low labels Mar 30, 2020
@jessicaschilling jessicaschilling changed the title Settings: Save button has low contrast and feels inactive Change save button contrast as global color edit Apr 7, 2020
@jessicaschilling jessicaschilling added effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked and removed P3 Low: Not priority right now labels Apr 7, 2020
@jessicaschilling
Copy link
Contributor

I'm going to change the color value in ipfs-shipyard/ipfs-css#40 -- once that's merged, OK to update the button itself from aqua to teal.

@jessicaschilling
Copy link
Contributor

ipfs-css has been updated to 1.0.0! Ready to integrate this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants