Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPNS CID should have association with cid in files tab #2663

Open
meandavejustice opened this issue Oct 11, 2023 · 10 comments
Open

IPNS CID should have association with cid in files tab #2663

meandavejustice opened this issue Oct 11, 2023 · 10 comments
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@meandavejustice
Copy link

meandavejustice commented Oct 11, 2023

Describe the bug
When viewing files in the files tab, I am always able to "Publish to IPNS" even if I have already published this file. It seems to me, the UI should know and reflect that. Also we should display/have the ability to copy the IPNS CID from this view

To Reproduce
Steps to reproduce the behavior:

  1. Import file
  2. Click on '....'
  3. Click "Publish to IPNS", choose key etc...
  4. Navigate away from view
  5. Repeat steps 2 and 3 and see that you get the same view.

Expected behavior

  • Publish to IPNS modal should show if the CID is published under a certain key (check mark or otherwise found via curl -X POST "http://127.0.0.1:5001/api/v0/name/resolve?recursive=true&dht-record-count=16&dht-timeout=1m0s" (see https://docs.ipfs.tech/reference/kubo/rpc/#api-v0-name-resolve)
  • Publish to IPNS modal should show list of all available keys to publish under

Screenshots
If applicable, add screenshots to help explain your problem.

image
image

Additional context
Add any other context about the problem here.

@meandavejustice meandavejustice added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Oct 11, 2023
@welcome
Copy link

welcome bot commented Oct 11, 2023

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@meandavejustice meandavejustice changed the title IPNS CID should have association with file in files tab IPNS CID should have association with cid in files tab Oct 11, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Oct 12, 2023
@SgtPooki
Copy link
Member

@meandavejustice thanks for submitting this feature request! I think this will need addressed in ipfs-webui, but I will get to triaging this soon.

@SgtPooki SgtPooki added help wanted Seeking public contribution on this issue exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up kind/enhancement A net-new feature or improvement to an existing feature good first issue Good issue for new contributors effort/hours Estimated to take one or several hours status/ready Ready to be worked labels Oct 13, 2023
@SgtPooki SgtPooki removed the need/triage Needs initial labeling and prioritization label Oct 26, 2023
@SgtPooki SgtPooki moved this from Needs Grooming to Planned / Backlog in IPFS-GUI (PL EngRes) Oct 26, 2023
@SamarthBagga
Copy link

Hi @SgtPooki, I'm eager to kick off work on this—unless someone else is already tackling it?

@SgtPooki
Copy link
Member

Hi @SgtPooki, I'm eager to kick off work on this—unless someone else is already tackling it?

No one is currently working on this to my knowledge!

Please go for it! Let me know if you need any assistance

@SamarthBagga
Copy link

Hi @SgtPooki, Can you confirm if the feature request involves adding a UI section to indicate whether a file has been published to IPFS?
If so, could you please specify the exact location in the UI where the information about the IPFS CID for the already published file should be displayed?

@SgtPooki
Copy link
Member

Hi @SgtPooki, Can you confirm if the feature request involves adding a UI section to indicate whether a file has been published to IPFS?

If so, could you please specify the exact location in the UI where the information about the IPFS CID for the already published file should be displayed?

@SamarthBagga we are currently on holiday break until the new year. I’d have to dive into this a bit further to propose UI specifics.

Maybe @meandavejustice could chime in here, otherwise I will be able to get back to you in early Jan.

@SamarthBagga
Copy link

okay sure!

@SgtPooki
Copy link
Member

SgtPooki commented Feb 1, 2024

@SamarthBagga sorry for taking so long to get back to you.

I would imagine we want something similar to the Pinning modal, where we list the pinning providers, with a checkbox next to them if they're already pinned with that provider.

Screenshot is below:

image

@SgtPooki
Copy link
Member

SgtPooki commented Feb 2, 2024

we should also add a new column to the files table to show which IPNS key the CID is published to, similar to "Pin Status"

image

@lidel
Copy link
Member

lidel commented Feb 6, 2024

Sounds sensible. We could even simplify "Pin Status" to "Status" and have megaphone icon there next to pin to indicate it was published with one of IPNS keys, and clicking on it opens the IPNS details modal you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

4 participants