Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Add to IPFS" on Windows does not open correct Files path #1815

Closed
lidel opened this issue May 4, 2021 · 0 comments · Fixed by #1853
Closed

"Add to IPFS" on Windows does not open correct Files path #1815

lidel opened this issue May 4, 2021 · 0 comments · Fixed by #1853
Labels
area/windows Windows effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented May 4, 2021 •
edited
Loading

Small UX bug (ipfs-desktop 0.15.0 on Windows 10):

  • Right-click on a file and "Add to IPFS" from context menu works as expected: A notification is displayed, File import correctly, Correct link is copied to clipboard.
  • Notification says that clicking on it will open imported file in webui (Files screen), but clicking on it opens #/blank route

Screenshots
ipfs_desktop_screenshot_bugreport_imported_files_click_on_notification

This looks like a regression caused by ipfs/ipfs-webui#1259 or a later refactor.
@lidel lidel transferred this issue from ipfs/ipfs-webui May 5, 2021
@lidel lidel added the need/triage Needs initial labeling and prioritization label May 5, 2021
@lidel lidel added area/windows Windows effort/hours Estimated to take one or several hours P1 High: Likely tackled by core team if no one steps up exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) and removed need/triage Needs initial labeling and prioritization labels May 21, 2021
lidel added a commit that referenced this issue Jun 23, 2021
@lidel
wip: focus window before navigating
abe0c0d 
this aims to fix issue from
#1815

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel lidel mentioned this issue Jun 23, 2021
Merged
2 tasks
lidel added a commit that referenced this issue Jun 23, 2021
@lidel
fix: show Files after import on windows
fbcdc99 
this aims to fix issue from
#1815
@lidel lidel mentioned this issue Jun 24, 2021
Closed
lidel added a commit that referenced this issue Jun 24, 2021
@lidel
fix: show Files after import on windows
f5f40d7 
this aims to fix issue from
#1815
lidel added a commit that referenced this issue Jun 24, 2021
@lidel
fix: show Files after import on windows
1cc8fa4 
this aims to fix issue from
#1815
lidel added a commit that referenced this issue Jun 24, 2021
@lidel
fix: show Files after import on windows
9067623 
this aims to fix issue from
#1815
lidel added a commit that referenced this issue Jun 24, 2021
@lidel
fix: show Files after import on windows
12797b9 
this aims to fix issue from
#1815
lidel added a commit that referenced this issue Jun 24, 2021
@lidel
fix: show Files after import on windows
92c6eaf 
this aims to fix issue from
#1815
lidel added a commit that referenced this issue Jun 24, 2021
@lidel
fix: show Files after import on windows
a75d3ee 
this aims to fix issue from
#1815
lidel added a commit that referenced this issue Jun 24, 2021
@lidel
fix: show Files after import on windows
be83b64 
this aims to fix issue from
#1815
lidel added a commit that referenced this issue Jul 5, 2021
@lidel
fix: show Files after import on windows (#1853)
22d189c 
this aims to fix issue from
#1815
@tinytb tinytb moved this to Done in IP JS (PL EngRes) v2 Oct 14, 2022
@snyk-bot snyk-bot mentioned this issue May 22, 2023
Open
@SCOTT-GROUP-PRO SCOTT-GROUP-PRO mentioned this issue May 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/windows Windows effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IP JS (PL EngRes) v2
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: click on notification after import of files ipfs/ipfs-desktop
1 participant
@lidel