feat: support page actions for CID subdomains #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
added a commit
that referenced
this pull request
Nov 12, 2018
This is a fix of a regression for #537 that was introduced when X-Ipfs-Path header support was added. Until we are able to provide the same origin-based security guarantees at a local gateway, we should not redirect resources that use cid-in-subdomain deployment, as it is a strong hint they care about Origin-based isolation and we should not relax those guarantees.
lidel
added a commit
that referenced
this pull request
Nov 12, 2018
This is a fix of a regression for #537 that was introduced when X-Ipfs-Path header support was added. Until we are able to provide the same origin-based security guarantees at a local gateway, we should not redirect resources that use cid-in-subdomain deployment, as it is a strong hint they care about Origin-based isolation and we should not relax those guarantees.
lidel
commented
Oct 23, 2019
Comment on lines
+16
to
+18
| const fqdn = url.hostname.split('.') | ||
| const cid = fqdn[0] | ||
| const protocol = fqdn[1] |
There was a problem hiding this comment.
Just realized this won't produce correct results for gateways under multi-leveled domains such as cid.ipfs.something.co.uk.
Easy fix is to switch to is-ipfs, probably something like:
const { subdomainPattern } = require('is-ipfs')
const match = fqdn.match(subdomainPattern)
if (!match) throw new Error('no match for isIPFS.subdomainPattern')
const protocol = match[1]
const cid = match[2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #526 and adds some fail-safe tests.
Test URLs: http://bafkreigh2akiscaildcqabsyg3dfr6chu3fgpregiymsck7e7aqa4s52zy.ipfs.dweb.link