Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default redirect of DNSLink websites if it breaks Origin #701

Closed
lidel opened this issue Mar 22, 2019 · 2 comments · Fixed by #826
Closed

Disable default redirect of DNSLink websites if it breaks Origin #701

lidel opened this issue Mar 22, 2019 · 2 comments · Fixed by #826
Assignees
Labels
P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Mar 22, 2019

Extracted from parent issue: #667, read it for full context.

[..] with latest Beta (v2.7.5.762) we have almost all the pieces of the UX for ( B ):

What is missing: in case of DNSLink websites, we want to tweak this behaviour and disable redirect of DNSLink websites by default. People will still be able to opt-in via toggle introduced in (#687) and a global one in Preferences new menu item if they choose to do so, but the default should not change the Origin.

This will also solve the problem of websites hanging on initial load due to IPNS being slow ;-)

@lidel
Copy link
Member Author

lidel commented Mar 22, 2019

Note to self:

  • What if we disable redirect of the root document only (URL in location bar)? Everything loaded as a subresource would still be redirected to IPFS.
    • This may break some pages due CSP, and may degrade browsing experience due to discrepancy between root and subresource load speeds

@lidel lidel self-assigned this Mar 22, 2019
@lidel lidel added the P1 High: Likely tackled by core team if no one steps up label Mar 22, 2019
@lidel
Copy link
Member Author

lidel commented Dec 5, 2019

After chats with @autonome, @hugomrdias and @cwaring we decided to bump the priority of this.

Implementation notes:

lidel added a commit that referenced this issue Dec 5, 2019
In past, it was opt-out via redirect opt-out per hostname.
This changes default behavior and disables redirect of DNSLink websites
to local gateway, as noted in
#701

Adds DNSLink section to Preferences screen.

Closes #701, #667
@lidel lidel closed this as completed in #826 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant