Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future-proof integration tests #165

Closed
lidel opened this issue Nov 5, 2016 · 1 comment
Closed

Future-proof integration tests #165

lidel opened this issue Nov 5, 2016 · 1 comment
Labels
help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo status/blocked/missing-api Blocked by missing API status/blocked/upstream-bug Blocked by upstream bugs

Comments

@lidel
Copy link
Member

lidel commented Nov 5, 2016 •
edited
Loading

Current hack used for installing add-on before integration tests are run by geckodriver should be replaced with upstream API:

// This manually installs the add-on as a temporary add-on.
// Hopefully selenium/geckodriver will get a way to do this soon:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1298025

This issue will make sure we don't forget to switch to it when ready.

Ref.
@lidel lidel added the kind/maintenance Work required to avoid breaking changes or harm to project's status quo label Nov 5, 2016
@lidel lidel mentioned this issue May 31, 2017
Closed
@lidel lidel added the help wanted Seeking public contribution on this issue label Jul 22, 2017
@lidel lidel added status/blocked/missing-api Blocked by missing API status/blocked/upstream-bug Blocked by upstream bugs labels Oct 15, 2017
@lidel lidel mentioned this issue Oct 15, 2017
Merged
3 tasks
@lidel lidel changed the title Future-proof functional tests Future-proof integration tests Nov 20, 2017
lidel added a commit that referenced this issue Nov 20, 2017
@lidel
chore(test): extract PoC integration tests
6e4cd9d 
Ref.
#311 (comment)
#165
@lidel lidel mentioned this issue Nov 20, 2017
Merged
lidel added a commit that referenced this issue Nov 20, 2017
@lidel
chore(test): extract PoC integration tests
c34659b 
Ref.
#311 (comment)
#165
lidel added a commit that referenced this issue Jan 4, 2018
@lidel
chore: package.json bump + cleanup
cf63fcc 
- bumped some versions, eg. ipfs-api
- removed karma deps, no longer used
- removed PoC integration tests, added #165 as sub-item of #145
@lidel
Copy link
Member Author

lidel commented Jan 4, 2018

A lot changed since 2016, closing this one as a part of early spring cleaning ♻️
I removed legacy boilerplate (cf63fcc) and added a sub-task about integration tests to #145, we will track it there.

@lidel lidel closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo status/blocked/missing-api Blocked by missing API status/blocked/upstream-bug Blocked by upstream bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel