Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Property Getters #1129

Open
whizzzkid opened this issue Jan 13, 2023 · 0 comments
Open

Refactor: Property Getters #1129

whizzzkid opened this issue Jan 13, 2023 · 0 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo

Comments

@whizzzkid
Copy link
Contributor

Context: https://github.com/ipfs/ipfs-companion/pull/1125/files#r1067230334

In this comment:

  • Remove the Object.defineProperty methods and replace it with a class/object instances.
  • Validate serialization survives messaging between browser functions.
@whizzzkid whizzzkid added the need/triage Needs initial labeling and prioritization label Jan 13, 2023
@whizzzkid whizzzkid mentioned this issue Jan 13, 2023
Merged
@SgtPooki SgtPooki added kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo and removed need/triage Needs initial labeling and prioritization labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Planned / Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SgtPooki @whizzzkid