Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track URLs that failed to load because gateway was down. #1097

Open
1 task
whizzzkid opened this issue Sep 11, 2022 · 1 comment
Open
1 task

Track URLs that failed to load because gateway was down. #1097

whizzzkid opened this issue Sep 11, 2022 · 1 comment
Assignees
@whizzzkid
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up

Comments

@whizzzkid
Copy link
Contributor

whizzzkid commented Sep 11, 2022 •
edited by lidel
Loading

Is your feature request related to a problem? Please describe.
As part of #1092, we now have capability to reload the pages that failed to load because the gateway was offline. The check involves matching tab titles to validate if the page has content or did it fail. While this works, it won't work with non-english browsers or break in the future because the browsers could change the wording. I would like to improve the functionality to something like what @lidel suggested in the thread.

Describe the solution you'd like

  • Attach a listener to onErrorOccurred from src/lib/ipfs-request.js.
  • Add isRecoverableViaOnlineApi which stores failed requests to local gateway in a cache similar to errorInFlight.
  • Then, I could check if url is present in that cache, removing the need for matching titles.

Describe alternatives you've considered
An implementation using title matching has been provided in #1092.

Additional context

Additional tasks

  • add tests for local subdomain gateway: .ipns.localhost:8080 and for .ipfs.localhost:8080
@whizzzkid whizzzkid added the need/triage Needs initial labeling and prioritization label Sep 11, 2022
@whizzzkid
Copy link
Contributor Author

@lidel can you please assign this to me?

@whizzzkid whizzzkid mentioned this issue Sep 11, 2022
Merged
@lidel lidel added kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up effort/days Estimated to take multiple days, but less than a week labels Sep 26, 2022
@ipfs ipfs deleted a comment from welcome bot Sep 26, 2022
@SgtPooki SgtPooki removed the need/triage Needs initial labeling and prioritization label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Prioritized / Ready for Dev
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @SgtPooki @whizzzkid