Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

feat: port to new ipfsd-ctl #5

Merged
merged 10 commits into from
Jan 25, 2018
Merged

feat: port to new ipfsd-ctl #5

merged 10 commits into from
Jan 25, 2018

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Dec 21, 2017

No description provided.

@ghost ghost assigned dryajov Dec 21, 2017
@ghost ghost added the status/in-progress In progress label Dec 21, 2017
test/repo.js Outdated
expect(err).to.not.exist()
expect(fileData).to.eql(data)
callback()
})
}

describe('repo', () => {
it('read repo: go -> js', (done) => {
describe.skip('repo', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why skip? This was passing.

test/repo.js Outdated
repoPath: dir
}, cb),
(node, cb) => {
console.dir('HERE')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary console log

@@ -7,7 +7,7 @@ const os = require('os')
const path = require('path')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this file. It is not being used.

@dryajov dryajov mentioned this pull request Jan 11, 2018
6 tasks
@dryajov dryajov changed the title [WIP] feat: port to new ipfsd-ctl feat: port to new ipfsd-ctl Jan 15, 2018
@daviddias
Copy link
Member

ipfsd-ctl 0.27 has been published. Could you update the PR?

test/browser.js Outdated
@@ -3,6 +3,6 @@

// require('./exchange-files')
// require('./pubsub')
// require('./kad-dht')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a target of this PR, @dryajov

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests are being skipped either way - I added it to browser tests since it actually loads fine in the browser. I added it for consistency, but can remove if needed.

@dryajov
Copy link
Member Author

dryajov commented Jan 19, 2018

depends on - ipfs/js-ipfsd-ctl#184

@daviddias
Copy link
Member

@dryajov I see that the Circuit Relay tests are the ones failing. Wanna separate the work on enabling those tests from the PR adding the new ipfsd-ctl?

@dryajov
Copy link
Member Author

dryajov commented Jan 25, 2018

sure! we can move the tests into its own PR. Should I remove the circuit tests from this PR completely, or just skip those that are failing? I'd rather remove them completely TBH.

@daviddias
Copy link
Member

@dryajov your choice

@dryajov
Copy link
Member Author

dryajov commented Jan 25, 2018

moved circuit relay tests to #6

@dryajov dryajov mentioned this pull request Jan 25, 2018
@daviddias daviddias merged commit 41ee565 into master Jan 25, 2018
@daviddias daviddias deleted the feat/ipfsd-ctl branch January 25, 2018 20:25
@ghost ghost removed the status/in-progress In progress label Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants