-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
test/repo.js
Outdated
expect(err).to.not.exist() | ||
expect(fileData).to.eql(data) | ||
callback() | ||
}) | ||
} | ||
|
||
describe('repo', () => { | ||
it('read repo: go -> js', (done) => { | ||
describe.skip('repo', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why skip? This was passing.
test/repo.js
Outdated
repoPath: dir | ||
}, cb), | ||
(node, cb) => { | ||
console.dir('HERE') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary console log
@@ -7,7 +7,7 @@ const os = require('os') | |||
const path = require('path') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this file. It is not being used.
53e391b
to
78c4c10
Compare
ipfsd-ctl 0.27 has been published. Could you update the PR? |
e95cbb6
to
48dccef
Compare
bbed9e5
to
762d9f4
Compare
test/browser.js
Outdated
@@ -3,6 +3,6 @@ | |||
|
|||
// require('./exchange-files') | |||
// require('./pubsub') | |||
// require('./kad-dht') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a target of this PR, @dryajov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those tests are being skipped either way - I added it to browser tests since it actually loads fine in the browser. I added it for consistency, but can remove if needed.
depends on - ipfs/js-ipfsd-ctl#184 |
2c9d8af
to
4716ef3
Compare
@dryajov I see that the Circuit Relay tests are the ones failing. Wanna separate the work on enabling those tests from the PR adding the new ipfsd-ctl? |
sure! we can move the tests into its own PR. Should I remove the circuit tests from this PR completely, or just skip those that are failing? I'd rather remove them completely TBH. |
@dryajov your choice |
moved circuit relay tests to #6 |
No description provided.