This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: ipns over pubsub tests #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
fix/ipns-over-pubsub-tests
branch
from
4413ba5
to
3e619e1
Compare
7 tasks
alanshaw
suggested changes
Nov 30, 2018
alanshaw
suggested changes
Dec 3, 2018
vasco-santos
force-pushed
the
fix/ipns-over-pubsub-tests
branch
from
a8002e5
to
c6995d6
Compare
alanshaw
approved these changes
Dec 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an IPNS record value in cache, we will not hit the resolver and consequently, we are not going to subscribe the topic, as it is only subscribed when we are looking for it.
According to the above, I removed the
publishprior to theresolvein the tests, which lead to some changes in the structure of the test, as resolve will return an error, as a consequence of not having any record.