This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: ensure test for resolve recursive has another node #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resolve IPNS link recursively test uses name.publish to publish an IPNS link as the value for the peer. It then uses resolve to resolve the peer ID and recursively then resolve the IPNS link. This fixes the test so that when name.publish is called there is another connected node to publish to so that we do not get the error "failed to find any peer in table", in the case that the node has not yet connected to any other peers. License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolve IPNS link recursively test uses name.publish to publish an IPNS link as the value for the peer. It then uses resolve to resolve the peer ID and recursively then resolve the IPNS link.
This fixes the test so that when name.publish is called there is another connected node to publish to so that we do not get the error "failed to find any peer in table", in the case that the node has not yet connected to any other peers.