fix: unsubscribe in series for go-ipfs (#326)

License: MIT Signed-off-by: Alan Shaw <[email protected]>
ipfs-inactive · Jul 16, 2018 · 8e487da · 8e487da
1 parent 87a8f96
commit 8e487da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/js/src/pubsub/ls.js b/js/src/pubsub/ls.js
@@ -1,7 +1,6 @@
 /* eslint-env mocha */
 'use strict'
 
-const each = require('async/each')
 const eachSeries = require('async/eachSeries')
 const { getTopic } = require('./utils')
 const { getDescribe, getIt, expect } = require('../utils/mocha')
@@ -80,7 +79,7 @@ module.exports = (createCommon, options) => {
           expect(list.sort())
             .to.eql(topics.map((t) => t.name).sort())
 
-          each(topics, (t, cb) => {
+          eachSeries(topics, (t, cb) => {
             ipfs.pubsub.unsubscribe(t.name, t.handler, cb)
           }, done)
         })

diff --git a/js/src/pubsub/unsubscribe.js b/js/src/pubsub/unsubscribe.js
@@ -1,7 +1,7 @@
 /* eslint-env mocha */
 'use strict'
 
-const each = require('async/each')
+const eachSeries = require('async/eachSeries')
 const timesSeries = require('async/timesSeries')
 const { getTopic } = require('./utils')
 const { getDescribe, getIt, expect } = require('../utils/mocha')
@@ -42,7 +42,7 @@ module.exports = (createCommon, options) => {
         ipfs.pubsub.subscribe(someTopic, handler, (err) => cb(err, handler))
       }, (err, handlers) => {
         expect(err).to.not.exist()
-        each(
+        eachSeries(
           handlers,
           (handler, cb) => ipfs.pubsub.unsubscribe(someTopic, handler, cb),
           (err) => {