Skip to content
This repository has been archived by the owner on Mar 25, 2022. It is now read-only.

solarnet: add prometheus on pluto #28

Merged
1 commit merged into from
Jul 5, 2015
Merged

solarnet: add prometheus on pluto #28

1 commit merged into from
Jul 5, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 3, 2015

Scrapes all gateway hosts' /debug/metrics/prometheus and provides a query API and UI.

See it in action: http://pluto.i.ipfs.io/prometheus/graph#[{%22range_input%22%3A%221h%22%2C%22end_input%22%3A%22%22%2C%22step_input%22%3A%22%22%2C%22stacked%22%3A%22%22%2C%22expr%22%3A%22ipfs_p2p_peers_total%22%2C%22tab%22%3A0}]

Prometheus runs its default config, with only the scraping targets added. I left out authentication because I'm not sure it needs to be protected. @jbenet @whyrusleeping wdyt?

License: MIT
Signed-off-by: Lars Gierth <[email protected]>
@whyrusleeping whyrusleeping mentioned this pull request Jul 3, 2015
44 tasks
@jbenet
Copy link
Member

jbenet commented Jul 3, 2015

@lgierth this is very nice! i like it a lot.

I left out authentication because I'm not sure it needs to be protected.

People could use this information to do monitoring + targetting based on content. not with these metrics, but as we add more, they could. (could even give people a gateway link, and check when they accessed it). Let's put it behind auth for now, as this is a security + privacy concern. We can make it easy to get access -- i.e. give people in the community access as they request it -- but not have a public endpoint where we dont know what people are using it for.

@jbenet
Copy link
Member

jbenet commented Jul 3, 2015

and code LGTM! 👍

@ghost
Copy link
Author

ghost commented Jul 5, 2015

Merging this as-is since it's the current state of pluto, will add authentication first thing tomorrow.

ghost pushed a commit that referenced this pull request Jul 5, 2015
solarnet: add prometheus on pluto
@ghost ghost merged commit 4da722b into master Jul 5, 2015
@ghost ghost deleted the prometheus branch July 5, 2015 12:03
@jbenet jbenet removed the in progress label Jul 5, 2015
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant