Skip to content
This repository has been archived by the owner on Mar 25, 2022. It is now read-only.

Force HTTPS for path-based requests to dweb.link #479

Closed
lidel opened this issue Mar 7, 2019 · 3 comments
Closed

Force HTTPS for path-based requests to dweb.link #479

lidel opened this issue Mar 7, 2019 · 3 comments
Assignees
Labels
need/community-input Needs input from the wider community

Comments

@lidel
Copy link
Member

lidel commented Mar 7, 2019

Background

I believe that if dweb.link aims to replace ipfs.io as the default gateway,
we should also support path-based addressing.

Problem

Right now unencrypted requests for dweb.link/ipfs/* work, but do not redirect to HTTPS:

Explicit request over HTTPS produces certificate error:

Fix

This looks like a bug, so I think we want to redirect to HTTPS and add HSTS header.
(Possibly reusing fixes from #391 & #477 to dweb.link itself).

@mburns mburns added the need/community-input Needs input from the wider community label Mar 13, 2019
@scout scout self-assigned this Mar 14, 2019
@lidel
Copy link
Member Author

lidel commented Mar 30, 2019

Update:

I think what we want for dweb.link is to always redirect to subdomain version.

That removes the risk of website under /ipfs/<cid-A> accessing cookies and localStorage of website under <cid-B>.ipfs.dweb.link

So we want http://dweb.link/ipfs/bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html to return HTTP 301 to https://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq.ipfs.dweb.link/wiki/Vincent_van_Gogh.html

@mburns mburns assigned mburns and unassigned scout May 25, 2019
@mburns
Copy link
Contributor

mburns commented May 1, 2020

@lidel
Copy link
Member Author

lidel commented May 2, 2020

@mburns mburns closed this as completed May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need/community-input Needs input from the wider community
Projects
None yet
Development

No branches or pull requests

3 participants