Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Properly report DNSLink errors vs other namesys errors #11

Closed
aschmahmann opened this issue Apr 20, 2021 · 1 comment
Closed

Properly report DNSLink errors vs other namesys errors #11

aschmahmann opened this issue Apr 20, 2021 · 1 comment
Assignees
@gammazero

Comments

@aschmahmann
Copy link
Contributor

#9 introduced a bug where it assumes many namesys errors are DNSLink errors (e.g. trying to download IPNS records when offline results in a failure that is reported as a DNSLink error instead of an IPNS error)

This PR should either be reverted (resulting in less precise DNSLink errors) or we should fix the error reporting so we keep the more precise DNSLink errors, but only when it's actually a DNSLink error.
@gammazero gammazero self-assigned this Apr 20, 2021
@gammazero gammazero mentioned this issue Apr 20, 2021
Merged
@lidel
Copy link
Member

lidel commented Apr 26, 2021

Closed in #12

@lidel lidel closed this as completed Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gammazero gammazero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @aschmahmann @gammazero