fix/go-ipfs-as-a-library #8266
Merged
fix/go-ipfs-as-a-library #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jul 19, 2021
|
Please rebase and force-push. The tests aren't running for some reason. |
lasiar
force-pushed
the
fix/go-ipfs-as-a-library
branch
from
2875818
to
de41430
Compare
|
Hm. Not sure why CircleCI isn't running jobs from forks. We'll have to do some digging... |
wrap error handling from connectToPeers in a closure
libp2p doesn't need alias
createTempRepo doesn't use context
Stebalien
force-pushed
the
fix/go-ipfs-as-a-library
branch
from
de41430
to
d00e965
Compare
Stebalien
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix go modules: run
go mod tidyRefactor:
connectToPeerslibp2pspawnDefaultcreateTempRepo