Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update experimental-features doc with IPNS over pubsub changes. #7334

Merged
merged 2 commits into from
May 20, 2020

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented May 20, 2020

Updates the IPNS over PubSub experimental feature to encompass the latest changes to the feature.

0.4.14
0.5.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether this should read as the "earliest version" (0.4.14) or "earliest version compatible with current version" (0.5.0).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have a version history, honestly.

docs/experimental-features.md Show resolved Hide resolved
docs/experimental-features.md Show resolved Hide resolved
@aschmahmann aschmahmann marked this pull request as ready for review May 20, 2020 05:35
0.4.14
0.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have a version history, honestly.

docs/experimental-features.md Show resolved Hide resolved
docs/experimental-features.md Show resolved Hide resolved
@aschmahmann aschmahmann force-pushed the docs/ipns-pubsub-experiment-update branch from 4ff899e to a38987a Compare May 20, 2020 16:49
Comment on lines +430 to +437
0.4.14 :
- Introduced

0.5.0 :
- No longer needs to use the DHT for the first resolution
- When discovering PubSub peers via the DHT, the DHT key is different from previous versions
- This leads to 0.5 IPNS pubsub peers and 0.4 IPNS pubsub peers not being able to find each other in the DHT
- Robustness improvements
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien is this the type of version history you were looking for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Stebalien Stebalien merged commit 554a21b into master May 20, 2020
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
@hacdias hacdias deleted the docs/ipns-pubsub-experiment-update branch May 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants