Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: add helptext #7265

Merged
merged 1 commit into from
May 8, 2020

Conversation

RubenKelevra
Copy link
Contributor

@RubenKelevra RubenKelevra commented May 1, 2020

General help text added to instruct new user to make permanent changes to the service files

Add a longer timeout for startup and shutdown Removed after discussions

@auto-comment
Copy link

auto-comment bot commented May 1, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

misc/systemd/ipfs.service Outdated Show resolved Hide resolved
misc/systemd/ipfs.service Outdated Show resolved Hide resolved
misc/systemd/ipfs.service Outdated Show resolved Hide resolved
misc/systemd/ipfs.service Outdated Show resolved Hide resolved
misc/systemd/ipfs.service Outdated Show resolved Hide resolved
@RubenKelevra RubenKelevra force-pushed the feat/longer_systemd_timeouts branch 2 times, most recently from 429013d to 90678f8 Compare May 5, 2020 08:19
@RubenKelevra RubenKelevra changed the title systemd: remove migrate-flag and add longer startup/stop timeouts + helptext systemd: add longer stop timeout + helptext May 6, 2020
@RubenKelevra
Copy link
Contributor Author

@Stebalien @hsanjuan ready for a new review :)

@Stebalien
Copy link
Member

Let's try to figure out why IPFS is taking so long to stop for you, not just extend the stop timeout.

@RubenKelevra
Copy link
Contributor Author

Let's try to figure out why IPFS is taking so long to stop for you, not just extend the stop timeout.

Sure.

I remove those changes from this PR as well since I like to push some other changed on this file in the next days and I want to avoid merge conflicts. :)

@RubenKelevra RubenKelevra force-pushed the feat/longer_systemd_timeouts branch from 90678f8 to 06abad7 Compare May 6, 2020 22:06
@RubenKelevra RubenKelevra changed the title systemd: add longer stop timeout + helptext systemd: add helptext May 6, 2020
@Stebalien Stebalien merged commit cfcd876 into ipfs:master May 8, 2020
@RubenKelevra RubenKelevra deleted the feat/longer_systemd_timeouts branch May 9, 2020 01:27
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants