Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module files for go-ipfs-as-a-library example #7146

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

lthibault
Copy link
Contributor

Fixes #6811.

@hsanjuan
Copy link
Contributor

Should we just document how to setup the example on a separate location?

My main issue with this is that we might forget to keep this go.mod up to date, therefore the example might break when people want to use it with newer go-ipfs versions.

@Stebalien
Copy link
Member

Eh, I'd add it. It's a good starting point.

However, we should probably wait till the release so we can make it depend on v0.5.0 instead of a specific git commit.

@hsanjuan hsanjuan added this to the go-ipfs 0.6 milestone Apr 14, 2020
@hsanjuan
Copy link
Contributor

I put it in the milestone so that we don't forget...

@Stebalien
Copy link
Member

@lthibault could you rebase this and update go-ipfs to 0.5.0?

@lthibault
Copy link
Contributor Author

@Stebalien Done.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien Stebalien merged commit d757450 into ipfs:master Apr 29, 2020
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding some go.mod information along the example
3 participants