cleanup daemon online logic #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never set this to true outside of tests and it's unclear what it's even supposed to do. This brings us back down to _two_ online-ish options from three. fixes #5787 License: MIT Signed-off-by: Steven Allen <[email protected]>
1. They don't _have_ to be mutually exclusive. 2. local, mode, etc is _really_ confusing. License: MIT Signed-off-by: Steven Allen <[email protected]>
ghost
assigned 
magik6k
approved these changes
Mar 5, 2019
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
cleanup daemon online logic This commit was moved from ipfs/kubo@4b57080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could still be cleaner but hopefully it's a bit less cryptic.