yamux: increase yamux window size to 8MiB. #6049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
we should do this in whyrusleeping/go-smux-yamux so that all libp2p programs benefit. |
Kubuxu
reviewed
Mar 5, 2019
core/core.go
Outdated
| @@ -418,7 +418,7 @@ func makeSmuxTransportOption(mplexExp bool) libp2p.Option { | |||
| ConnectionWriteTimeout: time.Second * 10, | |||
| KeepAliveInterval: time.Second * 30, | |||
| EnableKeepAlive: true, | |||
| MaxStreamWindowSize: uint32(1024 * 512), | |||
| MaxStreamWindowSize: uint32(1024 * 8192), | |||
There was a problem hiding this comment.
Suggested change
| MaxStreamWindowSize: uint32(1024 * 8192), | |
| MaxStreamWindowSize: uint32(8 << 20), |
I think it is much cleaner in showing it is 8MB.
There was a problem hiding this comment.
I've changed it to 8 * 1024 * 1024. I'm really not a fan of 8<<20.
This _should_ be variable. But, until we can get around to fixing that, 8MiB means a max speed of 40MiB given a 200ms RTT. The current limit gives us a 2.5MiB max rate which _really_ hurts. License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
fix/yamux-window-size
branch
from
fd7ee80
to
47f5c6c
Compare
Kubuxu
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be variable. But, until we can get around to fixing that, 8MiB means a max speed of 40MiB given a 200ms RTT. The current limit gives us a 2.5MiB max rate which really hurts.
Note: We now auto-shrink this buffer as needed (using a buffer pool) so this
shouldn't leak memory.