Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gogo-protobuf #5355

Merged
merged 1 commit into from
Aug 9, 2018
Merged

update gogo-protobuf #5355

merged 1 commit into from
Aug 9, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Aug 9, 2018

This includes:

  1. The latest gogo protobuf version. Note: I've intentionally stripped the tests from the package to shrink it to a more manageable size.
  2. Regenerated .pb.go files (except for those in go-merkledag).

It keeps the hashes the same by using the existing generated marshaler in go-merkledag. We can improve on this in the future by, e.g., regenerating everything except the marshaler.

fixes #3214

fixes #3214

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@Stebalien Stebalien requested a review from Kubuxu as a code owner August 9, 2018 01:56
@ghost ghost assigned Stebalien Aug 9, 2018
@ghost ghost added the status/in-progress In progress label Aug 9, 2018
@Stebalien Stebalien added the status/blocked Unable to be worked further until needs are met label Aug 9, 2018
@Stebalien
Copy link
Member Author

Want to make sure the tests pass first before I merge/push the rest of the updates to the dependencies.

@Stebalien
Copy link
Member Author

Stebalien commented Aug 9, 2018

Blocked on: ipfs/go-ipfs-config#2

@Stebalien Stebalien requested a review from magik6k August 9, 2018 02:34
@Stebalien Stebalien added need/review Needs a review and removed status/blocked Unable to be worked further until needs are met status/in-progress In progress labels Aug 9, 2018
@ghost ghost added the status/in-progress In progress label Aug 9, 2018
@Stebalien Stebalien removed the status/in-progress In progress label Aug 9, 2018
@Stebalien Stebalien merged commit 3296412 into master Aug 9, 2018
@Stebalien Stebalien deleted the feat/protobuf branch August 9, 2018 06:29
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
update gogo-protobuf

This commit was moved from ipfs/kubo@3296412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gogo protobuf dependency
2 participants