-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin: preload git plugin by default #4991
Conversation
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin would have to be imported through gx for it to work.
Can you figure out why CI failed?
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
Being able to do Git things is absolutely worth the 100KB :) |
The sha1 object thing by default bothers me slightly. Maybe we should just put efforts into getting the plugins up on dists? |
Maybe let's couple allowing sha1 to git CIDs only then. We'll have the same issue with js-ipfs and ipfs-companion. |
Alright, fine. You guys win this battle |
Suggested by @lgierth an IRC, enabling the git plugin is rather painful experience for anyone wanting to do anything git related:
Adding the plugin to preload_list adds about 100K to the binary size, and given that it is 43M it's rather negligible.