Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix t0063-daemon-init.sh by adding test profile to daemon #4816

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix t0063-daemon-init.sh by adding test profile to daemon #4816

merged 1 commit into from
Mar 23, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 15, 2018 •
edited
Loading

The test wouldn't pass when there was an ipfs daemon running on the system.

Added init-profile flag for ipfs daemon, works like the one in init.

Fixes #3457

@magik6k magik6k requested a review from Kubuxu as a code owner March 15, 2018 00:10
@ghost ghost assigned magik6k Mar 15, 2018
@ghost ghost added the status/in-progress In progress label Mar 15, 2018
Stebalien
Stebalien approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Kubuxu
Kubuxu approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipfs daemon has already a lot of options, I don't really love adding another one but we don't have another choice.

@Kubuxu Kubuxu added RFM and removed status/in-progress In progress labels Mar 15, 2018
@magik6k magik6k mentioned this pull request Mar 22, 2018
Merged
@whyrusleeping whyrusleeping merged commit b0ac2b8 into master Mar 23, 2018
@whyrusleeping whyrusleeping deleted the fix/t0063-test-profile branch March 23, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

@Stebalien Stebalien Stebalien approved these changes

Assignees

@magik6k magik6k

Labels
RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magik6k @Stebalien @Kubuxu @whyrusleeping