misc: add confirmation to archive-branches script #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Kubuxu
force-pushed
the
misc/arch-bash-confirm
branch
from
5289761
to
7734464
Compare
|
Does anyone see branch that shouldn't be moved to an archive in this list: Please give 👍 after you check and rise a comment if there is something that shouldn't be moved. |
Kubuxu
force-pushed
the
misc/arch-bash-confirm
branch
from
26a0151
to
dfbf1a3
Compare
magik6k
reviewed
Mar 9, 2018
bin/archive-branches.sh
Outdated
| while read -r ref; do | ||
| branches_to_move="$(cat <(active_branches) <(pr_branches) <((IFS=$'\n'; echo "${exclusions[*]}")) | sort -u | comm - <(origin_refs | sort) -13)" | ||
|
|
||
| echo "Please confirm move of following branches [y/N]:" |
There was a problem hiding this comment.
I'd echo this after printing the list
Kubuxu
added
need/review
Kubuxu
force-pushed
the
misc/arch-bash-confirm
branch
from
dfbf1a3
to
becf40c
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
misc/arch-bash-confirm
branch
from
becf40c
to
8b66077
Compare
magik6k
approved these changes
Mar 11, 2018
|
@kevina can you take a look? |
Kubuxu
added
RFM
and removed
status/in-progress
|
Enough time elapsed. I will move branches to archive after this is merged. |
whyrusleeping
approved these changes
Mar 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jakub Sztandera [email protected]