Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exchange.SessionExchange interface for exchanges that support sessions #4709

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

hsanjuan
Copy link
Contributor

Blockservice has an explicit dependency on bitswap so it can
call NewSession. It should rely on the exchange interfaces though, not
on specific implementations.

License: MIT
Signed-off-by: Hector Sanjuan [email protected]

…sions.

Blockservice has an explicit dependency on bitswap so it can
call NewSession. It should rely on the exchange interfaces though, not
on specific implementations.

License: MIT
Signed-off-by: Hector Sanjuan <[email protected]>
@hsanjuan hsanjuan self-assigned this Feb 15, 2018
@ghost ghost added the status/in-progress In progress label Feb 15, 2018
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@whyrusleeping whyrusleeping merged commit b9b1495 into master Feb 15, 2018
@whyrusleeping whyrusleeping deleted the feat/session-exchanges branch February 15, 2018 21:58
@ghost ghost removed the status/in-progress In progress label Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants