Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only construct bitswap event loggable if necessary #4533

Merged
merged 1 commit into from
Dec 31, 2017
Merged

only construct bitswap event loggable if necessary #4533

merged 1 commit into from
Dec 31, 2017

Conversation

Stebalien
Copy link
Member

Base58 encoding cids/peerIDs isn't exactly fast.

@Stebalien
only construct bitswap event loggable if necessary
914e653 
Base58 encoding cids/peerIDs isn't exactly fast.

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@ghost ghost assigned Stebalien Dec 29, 2017
@ghost ghost added the status/in-progress In progress label Dec 29, 2017
frrist
frrist approved these changes Dec 30, 2017
View reviewed changes
Copy link
Member

@frrist frrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

whyrusleeping
whyrusleeping approved these changes Dec 31, 2017
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though i'm thinking that we should add a method to loggables that looks like:

func (l Lgbl) AddInfoTo(m map[string]interface{}) {
    ...
}

so we can avoid all this 'deep merge' nonsense deeper down in the lib

@whyrusleeping whyrusleeping merged commit 026d873 into master Dec 31, 2017
@ghost ghost removed the status/in-progress In progress label Dec 31, 2017
@whyrusleeping whyrusleeping deleted the nit/bitswap-loggable branch December 31, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frrist frrist frrist approved these changes

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stebalien @whyrusleeping @frrist