optimise pin update command #4348
Conversation
ghost
assigned 
This handles merkle links that aren't named. And improves the Peergos usage from worst case 30s to ~20ms License: MIT Signed-off-by: Ian Preston <[email protected]>
ianopolous
force-pushed
the
fix/pin_update_opt
branch
from
a8135b2
to
885de4f
Compare
| var aonly []*cid.Cid | ||
| for _, l := range b.Links() { | ||
| inb[l.Cid.KeyString()] = l | ||
| } | ||
| for _, l := range a.Links() { |
There was a problem hiding this comment.
It will be faster to just call KeyString() once, bind it to a local variable here. (also easier on memory)
merkledag/utils/diffenum.go
Outdated
| } | ||
|
|
||
| var out []diffpair | ||
| var aindex = 0 |
There was a problem hiding this comment.
you can just say var aindex int
License: MIT Signed-off-by: Ian Preston <[email protected]>
ianopolous
force-pushed
the
fix/pin_update_opt
branch
2 times, most recently
from
8e4d5e9
to
825add0
Compare
|
I think we should make sure that the name pairing still works properly with this change, so that links with the same name (or 'path' within the object) still create the same resulting 'change' object |
|
I believe that the name matching property will be maintained with this pr, as long as the Links() function is only a function of the ipld topology of the object. I will write a test to verify this. |
ianopolous
force-pushed
the
fix/pin_update_opt
branch
from
d4d442a
to
ab9e491
Compare
License: MIT Signed-off-by: Ian Preston <[email protected]>
ianopolous
force-pushed
the
fix/pin_update_opt
branch
from
ab9e491
to
4f11baa
Compare
| @@ -65,27 +65,35 @@ type diffpair struct { | |||
| // getLinkDiff returns a changeset between nodes 'a' and 'b'. Currently does | |||
| // not log deletions as our usecase doesnt call for this. | |||
| func getLinkDiff(a, b node.Node) []diffpair { | |||
| have := make(map[string]*node.Link) | |||
| names := make(map[string]*node.Link) | |||
There was a problem hiding this comment.
Looks right. The Name property of links is a protonode thing (that needs to die).
|
Hooray! My first commits to go-ipfs! :-) |
This handles merkle links that aren't named. And improves the
Peergos usage from worst case 30s to ~20ms