Dockerfiles: do not set gecos field on user add. Set group. #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was unintended: useradd -g sets the gecos field to "100". Probably we meant to use -G to set the ipfs user group. -G does not take gids, so it needs to be set by name. The group with gid 100 is "users". Additionally, since we install the ca-certificates package (which is already installed), at least we should attempt to update it to get the latest version of certs. License: MIT Signed-off-by: Hector Sanjuan <[email protected]>
ghost
added
the
ghost
approved these changes
Oct 22, 2017
There was a problem hiding this comment.
Ooops, you're right: https://busybox.net/downloads/BusyBox.html#adduser
Thanks!
Kubuxu
approved these changes
Oct 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was unintended: useradd -g sets the gecos field to "100".
Probably we meant to use -G to set the ipfs user group.
-G does not take gids, so it needs to be set by name.
The group with gid 100 is "users".
Additionally, since we install the ca-certificates package
(which is already installed), at least we should attempt to update it
to get the latest version of certs.
License: MIT
Signed-off-by: Hector Sanjuan [email protected]