Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add raw support to the dag put command. #4285

Merged
merged 1 commit into from
Oct 11, 2017
Merged

add raw support to the dag put command. #4285

merged 1 commit into from
Oct 11, 2017

Conversation

Stebalien
Copy link
Member

dag get still doesn't properly support raw output but that's a bigger issue.

License: MIT
Signed-off-by: Steven Allen [email protected]

@Stebalien
Copy link
Member Author

Note: dag get $raw_node_hash still doesn't work properly because RawNode can't be marshaled to JSON. To do this correctly, we really need a nice way to convert between IPLD formats (assuming that IPLD nodes implement a JSON marshaler isn't really a solution).

@whyrusleeping
Copy link
Member

CircleCI is failing for some reason

@Stebalien
Copy link
Member Author

@whyrusleeping #4282

@Stebalien
add raw support to the dag put command.
613508a 
`dag get` still doesn't properly support raw output but that's a bigger issue.

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@whyrusleeping whyrusleeping merged commit e7acb96 into master Oct 11, 2017
@whyrusleeping whyrusleeping deleted the feat/raw-dag branch October 11, 2017 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @whyrusleeping