Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: add Nix to the linux package managers #3939

Merged
merged 1 commit into from
May 25, 2017

Conversation

WilliButz
Copy link
Contributor

No description provided.

README.md Outdated
@@ -71,6 +71,7 @@ From there:

- [Arch Linux](#arch-linux)
- [Snap](#snap)
- [Nix](#nix)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's to alphabetical order here and bellow as then distro wars can't happen about the order.

@WilliButz WilliButz force-pushed the master branch 2 times, most recently from 7752f94 to 1e818c5 Compare May 24, 2017 13:28
Copy link
Contributor

@mateon1 mateon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor nitpick.

Also, please remember to add Signed-off-by and License headers to your commit message.

README.md Outdated

For Linux and MacOSX you can use the purely functional package manager [Nix](https://nixos.org/nix/):

$ nix-env -i ipfs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably mention the attribute name (also ipfs) as well.

@WilliButz WilliButz force-pushed the master branch 3 times, most recently from 364cfe0 to 6dee6ca Compare May 25, 2017 10:08
@WilliButz
Copy link
Contributor Author

Okay, I'ts updated now @mateon1, @Kubuxu :)

README.md Outdated
```
or
```
$ nix-env -iA nixos.ipfs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main channel isn't necessarily named nixos. For the Nix package manager on other systems this would be nixpkgs, and could be named anything. I'd add a note like "The attribute name for the package is also ipfs" or "If you want to install by attribute name, it's also ipfs" instead of this code block.
Sorry for being so picky.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I appreciate the pickiness :)

Copy link
Contributor

@mateon1 mateon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whyrusleeping whyrusleeping merged commit c1f658c into ipfs:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants