Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for "commands".Command.Run #3382

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

keks
Copy link
Contributor

@keks keks commented Nov 14, 2016

To clarify that if you want to access the request body after writing need to use multipart requests.

This came up in #3304 (comment) and is relevant to #3367.

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a sensible enough place for this, though we should clarify at the beginning of the 'Note' something like "When executing commands over the http api..."

To clarify that if you want to access the request body after writing need to use
multipart requests.

License: MIT
Signed-off-by: Jan Winkelmann <[email protected]>
@whyrusleeping whyrusleeping merged commit bbd7ad2 into ipfs:master Nov 15, 2016
@whyrusleeping
Copy link
Member

Thanks @keks!

@ghost ghost mentioned this pull request Dec 23, 2016
@keks keks deleted the feat/command.run-docs branch November 22, 2017 18:42
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants