Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharness: fix typo in hash in t0050 #3170

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Conversation

whyrusleeping
Copy link
Member

was integrating CIDv0 into the codebase and flushed out this bug

License: MIT
Signed-off-by: Jeromy [email protected]

License: MIT
Signed-off-by: Jeromy <[email protected]>
@whyrusleeping whyrusleeping added the status/in-progress In progress label Sep 1, 2016
@whyrusleeping whyrusleeping added this to the ipfs 0.4.4 milestone Sep 1, 2016
@whyrusleeping whyrusleeping added need/review Needs a review and removed status/in-progress In progress labels Sep 1, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Sep 2, 2016

LGTM, does it mean there is some other issue with mulihash or base58? It should have probably refused to work.

@whyrusleeping whyrusleeping merged commit 3303fea into master Sep 2, 2016
@whyrusleeping whyrusleeping deleted the fix/test/block-hash branch September 2, 2016 13:26
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants